Skip to content

refactor: added ReceiveCaasFileConfig class to manage configuration.#731

Merged
SamAinsworth-NHS merged 13 commits intomainfrom
Add-Config-Receive-Cass-File
Mar 20, 2025
Merged

refactor: added ReceiveCaasFileConfig class to manage configuration.#731
SamAinsworth-NHS merged 13 commits intomainfrom
Add-Config-Receive-Cass-File

Conversation

@SamAinsworth-NHS
Copy link
Copy Markdown
Contributor

Description

A small first PR that manages configuration within a simple object. This pulls receiveCaasFile in line with the way RetrieveMeshFile works.

Added new class to contain configuration - receiveCaasFile/receiveCaasFileConfig.cs
Changed Program.cs within receiveCaasFile to fill and use this class during startup

Context

Brings functions in line

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

Joseph2910
Joseph2910 previously approved these changes Feb 26, 2025
@sonarqubecloud
Copy link
Copy Markdown

Swapnil261188
Swapnil261188 previously approved these changes Feb 26, 2025
@stephhou stephhou added the config Changes to the config for platform improvement label Mar 10, 2025
Joseph2910
Joseph2910 previously approved these changes Mar 11, 2025
sudipnhs
sudipnhs previously approved these changes Mar 11, 2025
@SamAinsworth-NHS SamAinsworth-NHS dismissed stale reviews from sudipnhs and Joseph2910 via 6a2ebb6 March 20, 2025 11:58
@SamAinsworth-NHS SamAinsworth-NHS added this pull request to the merge queue Mar 20, 2025
Merged via the queue into main with commit 53fc73b Mar 20, 2025
11 checks passed
@SamAinsworth-NHS SamAinsworth-NHS deleted the Add-Config-Receive-Cass-File branch March 20, 2025 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

config Changes to the config for platform improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants